Remove unneeded parameters on SourceCard
#1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
changed the title
SourceCard
|
Great fix and love the random improvements while we're at it. LGTM. |
|
Man, you guys really went above and beyond. I was hoping to see more XML documentation on some those request and response object so I don't have to go cross reference with the documentation all the time and Olivier did just that without anyone mentioned anything. Good stuff... |
|
We aim to please ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
SourceCardis the class used to store raw card parameters in charge creation requests, customer creation & update requests, card creation requests, and subscription creation & update requests. (It's unrelated to the sources API.)This PR:
capture,destinationandstatement_descriptorparameters (none of which are supported by the API in card hashes)Fixes #1112.