Adds the FailureReason property to StripeRedirect
#1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandur-stripe @AFallad asked in #1121 if we could declare constants with the possible values for this property. I think we can do one better and create an enum type -- we currently have only one in the entire library ( |
We're currently missing the `FailureReason` property which is documented here [1]. This patch adds it. We do something slightly unusual (so far) here by adding reasons as a new new called `StripeRedirectFailureReason`. There is only one other documented instance of this in the library in `StripeBilling`, but we might want to further pursue this pattern elsewhere in the future. Fixes #1118. [1] https://stripe.com/docs/api#source_object-redirect-failure_reason
brandur-stripe
force-pushed
the
brandur-failure-reason
branch
from
50dba48 to
7d0dc22
Compare
|
@ob-stripe Yeah, great point. There's a slight disadvantage in the enum in that there's no way for users to access a new value without first reporting the problem to us (given our current machinery, it's unlikely we'll notice ourselves), but we have this problem already for properties on classes anyway, so I wouldn't have a problem with trying this out. I've updated the pull request. Can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently missing the
FailureReasonproperty which is documentedhere [1]. This patch adds it.
Fixes #1118.
[1] https://stripe.com/docs/api#source_object-redirect-failure_reason
r? @ob-stripe