Use parser plugins during SubscriptionItemUpdatedPlugin item creation #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TobiasMelen, thanks for the contribution!
Yeah, it's slightly hacky, but the state of parameter encoding in stripe-dotnet isn't great (there's a lot of special casing) and subscription items encoding in particular has required special casing anyway in our other language libraries. Your fix is fine with me, pending a larger rewrite of the parameter encoding logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the SubscriptionItemPlugin use the parser plugins in RequestStringBuilder when creating request values for items in subscription update. This solves an issue with the input metadata parsing. The Metadata dictionary property needs to be parsed by DictionaryParserPlugin to create a valid Stripe request.
An inline JsonPropertyAttribute is created, which isn't pretty. Any other change would require a larger refactor.
I had to run the project locally with XUnit 2.3.0 due to Visual Studio issues, so the testcode should probably be validated on XUnit 2.2.0.
Fixes #1142.