Disable Topups tests as it breaks the Test suite because it's brittle

[remi-stripe]

Topups creation requires a Source to be chargeable. In Test mode this can take a random time though which leads to sporadic/random build failures.

For now we disable the tests as the resource works already and is still in private beta anyway.

Fixes #1110 (comment)

r? @brandur-stripe
cc @stripe/api-libraries

[brandur-stripe]

Good call.

Minor nit: instead of commenting everything out, what do you think about skipping the topup tests? The advantage here is that we get a basic guarantee that at least the tests still compile (even if they don't run correctly), which is kind of nice.

It should be possible skip them with the Skip attribute on Fact:

[Fact(Skip="Feature is private beta and tests are non-deterministic")]

[remi-stripe]

ah neat, I did not know about that feature but I confirmed the tests are skipped locally!

PTAL

[remi-stripe]

ah no I lied. This still creates a topup source in the fixtures I think.

[remi-stripe]

Yeah I confirmed in my logs, every time I run that test suite it still creates the topup (or tries) so the issue is still here.

Do you have another idea?

[brandur-stripe]

ah no I lied. This still creates a topup source in the fixtures I think.

Ah, dang. Maybe just minimize the commenting then by just commenting out the contents of public topups_fixture() in src/Stripe.Tests.XUnit/topups/_fixture.cs? I guess that's still a little better.

[remi-stripe]

Okay, done by commenting the minimum amount of code in the fixture. PTAL

[brandur-stripe]

LGTM. Thanks.