Add extra properties to the Invoice object #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Jun 13, 2018
| @@ -31,6 +34,8 @@ public class StripeInvoice : StripeEntityWithId, ISupportMetadata | |||
| [JsonProperty("billing")] | |||
| public StripeBilling? Billing { get; set; } | |||
|
|
|||
| public string BillingReason { get; set; } | |||
There was a problem hiding this comment.
minor but I almost created an Enum and then realized there are like 2 files today. We should discuss the benefits of Enums and whether it's worth porting all the properties to Enums (which I would happily do if so)
ob-stripe
approved these changes
Jun 20, 2018
|
Released in 16.11.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
amount_remainingandbilling_reasonto the Invoice object.r? @ob-stripe
cc @stripe/api-libraries