Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'customer.source.expiring' event and fix a typo #1210

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

karlr-stripe
Copy link
Contributor

Two changes here :

  1. Adding a CustomerSourceExpiring StripeEvent for https://stripe.com/docs/api#event_types-customer.source.expiring
  2. Updating CustomerSourcedDeleted -> CustomerSourceDeleted

I can back out the second change if we're worried about backwards compatibility or anything.

@remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

@karlr-stripe Thank you for the fix! Since we rename an event property it's likely a breaking change though.

@rattrayalex-stripe rattrayalex-stripe changed the title Add the 'customer.source.exiring' event and fix a typo Add the 'customer.source.expiring' event and fix a typo Jun 15, 2018
@adamtay
Copy link

adamtay commented Jul 10, 2018

Hi, any updates on adding the customer.source.deleted event to the API?

@remi-stripe
Copy link
Contributor

@adamtay The event is in the library, it's just with a typo but you can use it. We're going to try to merge this one in the next few days

@ob-stripe ob-stripe merged commit 3abb2e2 into stripe:master Jul 11, 2018
@ob-stripe
Copy link
Contributor

Released in 17.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants