Add support for passing level III data when creating a charge #1216
Conversation
|
|
||
| namespace Stripe.Infrastructure.Middleware | ||
| { | ||
| internal class ChargeLevel3Plugin : IParserPlugin |
There was a problem hiding this comment.
We really should revisit how plugins work. It's all copy/pasta for the sake of adding one list of items. There has to be a better way
There was a problem hiding this comment.
Agreed. I took a stab at this in #1218.
|
|
||
| namespace Stripe | ||
| { | ||
| public class StripeChargeLevel3LineItemOptions : INestedOptions |
There was a problem hiding this comment.
I still don't understand when something should be called Options versus Option.
There was a problem hiding this comment.
I think it should always be Options.
There was a problem hiding this comment.
Yeah that would work. I thought that we started using Option for nested ones to differentiate them from the top-level ones.
| { | ||
| public class StripeChargeLevel3Options : INestedOptions | ||
| { | ||
| [JsonProperty("level3[merchant_reference]")] |
There was a problem hiding this comment.
This works but since the parent has JsonProperty(level3) why isn't it passed to the lower level and you have to repeat it? The same happened to shipping.
| /// </summary> | ||
| // this will actually send `line_items`. this is to flag it for the middleware | ||
| // to process it as a plugin | ||
| [JsonProperty("charge_level3_line_items_array")] |
There was a problem hiding this comment.
This hack makes me sad each time I have to use it (and grep to find it again).
remi-stripe
changed the title
|
changed to [WIP] as this requires changes to the Charge ressource too but those are behind a gate |
remi-stripe
force-pushed
the
remi-add-level3
branch
from
469c123 to
f8f80de
Compare
remi-stripe
changed the title
|
Okay pushed a new version that can handle the returned |
remi-stripe
force-pushed
the
remi-add-level3
branch
from
cbc76d2 to
a133aa3
Compare
r? @ob-stripe
cc @stripe/api-libraries
cc @fred-stripe