Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename two properties that start with a lower case letter #1285

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Rename two properties that start with a lower case letter #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Stripe.net/Entities/StripeSku.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class StripeSku : StripeEntityWithId, ISupportMetadata
/// The URL of an image for this SKU, meant to be displayable to the customer.
/// </summary>
[JsonProperty("image")]
public string image { get; set; }
public string Image { get; set; }

/// <summary>
/// Description of the SKU’s inventory.
Expand Down
2 changes: 1 addition & 1 deletion src/Stripe.net/Services/Skus/StripeSkuSharedOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public abstract class StripeSkuSharedOptions : StripeBaseOptions, ISupportMetada
/// The URL of an image for this SKU, meant to be displayable to the customer.
/// </summary>
[JsonProperty("image")]
public string image { get; set; }
public string Image { get; set; }

/// <summary>
/// Description of the SKU’s inventory.
Expand Down
6 changes: 0 additions & 6 deletions src/_stylecop/StyleCopRules.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@
<Rule Id="SA1124" Action="None" />
<Rule Id="SA1202" Action="None" />

<!--
Keep this rule disabled as it affects `image` on SKU.
Fixing it would be a breaking change.
-->
<Rule Id="SA1300" Action="None" />

<!--
CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
SA1600: ElementsMustBeDocumented
Expand Down