Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross target netstandard2.0 #1297

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Cross target netstandard2.0 #1297

merged 1 commit into from
Sep 28, 2018

Conversation

iamcarbon
Copy link
Contributor

This PR adds netstandard2.0 to the target frameworks. This simplifies the dependency tree on modern runtimes.

@ob-stripe
Copy link
Contributor

Hi @iamcarbon, thanks for the contribution!

Can you clarify how this helps exactly? I'd've thought that libraries would only need to target the minimum version of .NET Standard that they require. Is that not the case?

@iamcarbon
Copy link
Contributor Author

Hey there. Targeting NETSTANDARD2.0 directly eliminates the 50+ dependencies that come from .NETSTANDARD 1.x libraries. .NETSTANDARD2.0 reduces this to a single dependency (netstsandard.dll) that is already included in modern runtimes (netfx472, netcoreapp2.0, etc).

The official guidance from MSFT is now to re-baseline at 2.0x or multi-target:
https://twitter.com/davidfowl/status/1008453902058917888

@ob-stripe
Copy link
Contributor

Cool, thanks @iamcarbon. Going to pull this in.

@ob-stripe ob-stripe merged commit 62b3656 into stripe:master Sep 28, 2018
@ob-stripe
Copy link
Contributor

Released as 19.9.2.

@ob-stripe
Copy link
Contributor

Just for future reference in case someone stumbles upon this: https://github.com/dotnet/standard/blob/master/docs/versions.md#how-do-i-know-which-net-standard-version-i-should-target

  • You should target the lowest version you can get away with.
  • If you target .NET Standard 1.x, add .NET Standard 2.0 as another target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants