Make internals visible to Newtonsoft.Json #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine to me but deferring to @anelder-stripe on this since he had the original suggestion. |
anelder-stripe
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
lgtm! Not sure how to test either, but please dm me when it's a published release, @ob-stripe! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @anelder-stripe @remi-stripe
cc @stripe/api-libraries
Make internals visible to Newtonsoft.Json, as suggested by @anelder-stripe in #971.
Unfortunately, I'm not sure if it's possible to write a test for this, but the change does make sense to me:
StripeDateTimeConverteris declared as aninternalclass, but it needs to be instantiated by Newtonsoft.Json when deserializing.