Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore culture when encoding parameters #1358

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Ignore culture when encoding parameters #1358

merged 1 commit into from
Oct 25, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Ignore culture when encoding parameters, to ensure they're encoded like the API expects.

Fixes #1357.

remi-stripe
remi-stripe reviewed Oct 25, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I would never have found this one. I'm assuming we're sure those are the only places where the bug can happen so approving.

@ob-stripe
Copy link
Contributor Author

ob-stripe commented Oct 25, 2018 •
edited
Loading

I disabled the test for netcoreapp1.1 because I couldn't find a way to make it work. It's tested with netcoreapp2.1 and net452, so that's good enough.

@ob-stripe ob-stripe assigned ob-stripe and unassigned remi-stripe Oct 25, 2018
@ob-stripe ob-stripe merged commit cd3a69a into master Oct 25, 2018
@ob-stripe ob-stripe deleted the ob-fix-1357 branch October 25, 2018 20:58
@ob-stripe
Copy link
Contributor Author

Released as 20.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe left review comments

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe