Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release changes to the Payment Intent APIs before release #1372

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Release changes to the Payment Intent APIs before release #1372

merged 1 commit into from
Nov 8, 2018

Conversation

remi-stripe
Copy link
Contributor

cc @stripe/api-libraries @danwang-stripe
r? @ob-stripe

@remi-stripe remi-stripe force-pushed the remi-change-payment-intents branch from 8be1fc2 to e319f89 Compare November 7, 2018 01:18
@remi-stripe remi-stripe force-pushed the remi-change-payment-intents branch from e319f89 to a09726e Compare November 7, 2018 03:49
ob-stripe
ob-stripe reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct to me. Can we wait until the OpenAPI spec has been updated to confirm that the new attributes and parameter names are correct though?

@remi-stripe
Copy link
Contributor Author

@ob-stripe openapi is already updated. But next_source_action is always null in stripe-mock since it can be multiple things so I have to use raw JSON to test all of this. It was already the case before the changes.

@ob-stripe
Copy link
Contributor

I was referring to the spec itself, not the fixtures. The current spec doesn't list on_behalf_of as an attribute on payment_intent, and still has return_url.

@remi-stripe
Copy link
Contributor Author

gotcha. Yeah unfortunately all of this is happening quite in parallel

@danwang
Copy link

danwang commented Nov 8, 2018

@ob-stripe This is fixed as of stripe/openapi@b9ff093 !

@remi-stripe
Copy link
Contributor Author

We would need to wait for stripe/stripe-mock#124 to be merged and released before we can integrate it. Thanks for doing that work @danwang

@remi-stripe remi-stripe force-pushed the remi-change-payment-intents branch from a09726e to 81092ba Compare November 8, 2018 22:35
@remi-stripe remi-stripe changed the base branch from master to remi-integration-21.0.0 November 8, 2018 22:35
@remi-stripe remi-stripe mentioned this pull request Nov 8, 2018
Merged
3 tasks
@remi-stripe remi-stripe merged commit 65de28b into remi-integration-21.0.0 Nov 8, 2018
@remi-stripe remi-stripe deleted the remi-change-payment-intents branch November 8, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe left review comments

Assignees

@ob-stripe ob-stripe

Labels
approved breaking-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remi-stripe @ob-stripe @danwang