Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML comments on interfaces #1387

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Add XML comments on interfaces #1387

merged 1 commit into from
Nov 12, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Add XML comments on IBalanceTransactionSource, IExternalAccount and IPaymentSource to provide an explicit list of concrete classes that implement the interfaces, so users know which types they should test when receiving one of these interfaces.

Fixes #1369.

@remi-stripe remi-stripe merged commit 5a7b741 into master Nov 12, 2018
@remi-stripe remi-stripe deleted the ob-xmldoc-interfaces branch November 12, 2018 15:18
@ob-stripe
Copy link
Contributor Author

Released as 21.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants