Add support for Terminal resources #1388
Conversation
There was a problem hiding this comment.
Left one comment, but looks great overall.
Also, could you add the new resources in the StripeObjectConverter dictionary? Not sure if these can appear in webhook events, but better safe than sorry. (Also, I think I forgot to ask you to do the same for the new Radar resources too.)
|
|
||
| public override string BasePath => "/terminal/connection_tokens"; | ||
|
|
||
| public virtual ConnectionToken Create(ConnectionTokenCreateOptions options, RequestOptions requestOptions = null) |
There was a problem hiding this comment.
I wonder if we should provide overloads with no options. It seems a little bit silly to force users to create a ConnectionTokenCreateOptions instance that contains nothing.
There was a problem hiding this comment.
I hear you but then it becomes a mess of overloads and I'm not a big fan, we saw what it did to stripe-java.
There was a problem hiding this comment.
Just tested it, and we can simply set null as the default value for the options argument. It still satisfies the interface and makes the argument optional without requiring an overload.
remi-stripe
force-pushed
the
remi-add-terminal
branch
from
7585321 to
ea8670c
Compare
|
@ob-stripe Already did for the |
remi-stripe
force-pushed
the
remi-add-terminal
branch
from
ea8670c to
8be061b
Compare
|
Released as 21.2.0. |
r? @ob-stripe
cc @stripe/api-libraries @stevene-stripe