Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTime deserialization #1395

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Fix DateTime deserialization #1395

merged 2 commits into from
Nov 16, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Removes DateTimeConverter from the list of global converters and apply it directly to DateTime properties via the JsonConverter attribute.

Updates tests to use JsonConvert.DeserializeObject<> instead of Mapper<>.MapFromJson to deserialize objects wherever possible.

@remi-stripe
Copy link
Contributor

@ob-stripe LGTM

@ob-stripe ob-stripe merged commit 5c60223 into master Nov 16, 2018
@ob-stripe ob-stripe deleted the ob-fix-datetime-deserialize branch November 16, 2018 09:38
@ob-stripe
Copy link
Contributor Author

Released as 21.4.1.

@ob-stripe ob-stripe mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe