Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RecipientActiveAccount with BankAccount #1418

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Replace RecipientActiveAccount with BankAccount #1418

merged 1 commit into from
Dec 11, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Remove the RecipientActiveAccount class.

Changes the type of Recipient.ActiveAccount to BankAccount instead.

Per the OpenAPI spec, this is the correct type.

@ob-stripe ob-stripe mentioned this pull request Dec 11, 2018
Merged
29 tasks
remi-stripe
remi-stripe approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though we're losing some properties like disabled and validated but not sure we care.

@ob-stripe
Copy link
Contributor Author

I'm fairly sure that the API doesn't return these anyway. They're replaced by status.

Thanks!

@ob-stripe ob-stripe merged commit 915d758 into integration-v23 Dec 11, 2018
@ob-stripe ob-stripe deleted the ob-remove-recipient-active-account branch December 11, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved breaking-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe