Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nullable properties on authorization_controls #1443

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Support nullable properties on authorization_controls #1443

merged 1 commit into from
Dec 21, 2018

Conversation

remi-stripe
Copy link
Contributor

Fixes #1442

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe mentioned this pull request Dec 21, 2018
Closed
@ob-stripe
Copy link
Contributor

ob-stripe commented Dec 21, 2018 •
edited
Loading

This is technically a breaking change, so should probably be bundled in the upcoming v22.

ob-stripe
ob-stripe approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's release this as a patch version, since Issuing is still in beta and the current version simply doesn't work.

@ob-stripe ob-stripe assigned remi-stripe and unassigned ob-stripe Dec 21, 2018
@remi-stripe remi-stripe merged commit ca03e2b into master Dec 21, 2018
@remi-stripe remi-stripe deleted the remi-fix-issuing-nullable branch December 21, 2018 16:21
@ob-stripe
Copy link
Contributor

Released as 21.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-stripe @ob-stripe