Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transfer_data and application_fee_amount to Invoice and Subscriptions #1469

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Add transfer_data and application_fee_amount to Invoice and Subscriptions #1469

merged 2 commits into from
Feb 13, 2019

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Jan 11, 2019 •
edited
Loading

This PRs add transfer_data and application_fee_amount support to Invoice and Subscription

r? @ob-stripe
cc @stripe/api-libraries

NOT asking for review yet as I want to double check that we don't need on_behalf_of for now.

@remi-stripe remi-stripe assigned ob-stripe and unassigned ob-stripe Jan 11, 2019
@remi-stripe
Copy link
Contributor Author

unassigning as there's some unknown about on_behalf_of right now

@remi-stripe remi-stripe force-pushed the remi-add-sub-new-properties branch from ae86c68 to 83d54c7 Compare February 12, 2019 19:12
@remi-stripe
Copy link
Contributor Author

@ob-stripe We originally wanted to wait until the release of on_behalf_of but this will take some time and we would like to unblock this feature for Billing ahead of the 2/19 launch for Charges.

ob-stripe
ob-stripe approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe ob-stripe assigned remi-stripe and unassigned ob-stripe Feb 13, 2019
@remi-stripe remi-stripe merged commit 8df3a62 into master Feb 13, 2019
@remi-stripe remi-stripe deleted the remi-add-sub-new-properties branch February 13, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-stripe @ob-stripe