Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize signature of OAuthTokenService.Deauthorize #1483

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Standardizes the signature of Deauthorize / DeauthorizeAsync methods on OAuthTokenService to accept an options class. (This is a breaking change.)

While I was at it, I also added basic support for stubbing requests in tests and wrote tests for OAuthTokenService.

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Jan 23, 2019
@ob-stripe ob-stripe force-pushed the ob-oauth-deauth-optins branch from 3afe2cc to 650821f Compare January 23, 2019 11:49
@ob-stripe
Copy link
Contributor Author

ob-stripe commented Jan 23, 2019

ptal @remi-stripe

Some things I'll fix in different PRs:

  • Add a new AuthorizeUrl utility method for forming the https://connect.stripe.com/oauth/authorize?... URL
  • Add support for Express accounts (we need to do this in all of our libs -- right now I think only stripe-ruby has it)
  • When calling Create, auto-fill ClientSecret with the secret API key if not already set

And kind of a much larger scope, but ideally:

  • Add support for checking request parameters in AssertRequest :)

@ob-stripe ob-stripe assigned remi-stripe and unassigned ob-stripe Jan 23, 2019
@ob-stripe ob-stripe assigned ob-stripe and unassigned remi-stripe Jan 23, 2019
@ob-stripe ob-stripe merged commit 02bc8df into integration-v23 Jan 23, 2019
@ob-stripe ob-stripe deleted the ob-oauth-deauth-optins branch January 23, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants