Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements in EventUtility #1500

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Minor improvements in EventUtility #1500

merged 1 commit into from
Feb 3, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe

Some minor improvements in EventUtility:

  • Moved SecureCompare() into StringUtils, and renamed it SecureEquals() as its behavior is more comparable to String.Equals() than String.Compare()
  • Wrote tests for StringUtils.SecureEquals()
  • Added XML comments to the public methods of EventUtility
  • Some code reformatting to keep lines under 100 characters where possible

@ob-stripe ob-stripe mentioned this pull request Feb 3, 2019
Merged
52 tasks
@ob-stripe ob-stripe assigned ob-stripe and unassigned remi-stripe Feb 3, 2019
@ob-stripe ob-stripe merged commit dc1e983 into integration-v23 Feb 3, 2019
@ob-stripe ob-stripe deleted the ob-secure-equals-stringutils branch February 3, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe