Fixes to FileService and OAuthTokenService #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Feb 10, 2019
| @@ -26,11 +23,15 @@ public FileService(string apiKey) | |||
|
|
|||
| public virtual File Create(FileCreateOptions options, RequestOptions requestOptions = null) | |||
| { | |||
| requestOptions = this.SetupRequestOptions(requestOptions); | |||
| requestOptions.BaseUrl = requestOptions.BaseUrl ?? StripeConfiguration.FilesBase; | |||
There was a problem hiding this comment.
I don't fully grasp that line and why it's needed. Since we always know we want FilesBase here why change it? Is it just for tests?
There was a problem hiding this comment.
Do you mean why it's
requestOptions.BaseUrl = requestOptions.BaseUrl ?? StripeConfiguration.FilesBase;instead of just
requestOptions.BaseUrl = StripeConfiguration.FilesBase;? If so, it's just because I think it's bad practice to silently overwrite an existing value. In practice, this doesn't change anything: BaseUrl is internal, so it cannot be set by library users, and there is no internal code that calls FileService.Create / CreateAsync.
There was a problem hiding this comment.
Yeah that's mostly what I meant. The dichotomy between what you know you want and what the other property could be! But all good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
In #1504, I inadvertently removed the part of the code that sends file creation requests to
files.stripe.comrather thanapi.stripe.com😱 Tests were still passing because in the test suite, we replace both hostnames withlocalhostsince stripe-mock handles both.It should be easier to test this once I'm done refactoring the requestor code.
The changes to
OAuthTokenServiceisn't a fix, it's just to make the code a bit cleaner by using standard creation methods.