Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of options classes #1527

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix a couple of options classes #1527

merged 1 commit into from
Feb 20, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe

Just noticed that there are a couple of options classes that inherit StripeEntity instead of INestedOptions.

remi-stripe
remi-stripe approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

booh sorry for messing those :(

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Feb 19, 2019
@ob-stripe
Copy link
Contributor Author

No worries, I should have caught it during the review too.

@ob-stripe ob-stripe merged commit 9469107 into master Feb 20, 2019
@ob-stripe ob-stripe deleted the ob-subscriptions-options-fix branch February 20, 2019 10:34
@ob-stripe
Copy link
Contributor Author

Fixed in 24.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe