Multiple fixes for PaymentIntent #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Feb 20, 2019
src/Stripe.net/Entities/PaymentIntents/PaymentIntentTransferData.cs
Outdated
Show resolved
Hide resolved
remi-stripe
force-pushed
the
remi-fix-payment-intent
branch
from
909ea1a to
f7e26ce
Compare
|
@ob-stripe I made some extra changes, can you re-review and if it's all good release a version? |
ob-stripe
suggested changes
Feb 21, 2019
src/Stripe.net/Services/PaymentIntents/PaymentIntentSharedOptions.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Entities/PaymentIntents/PaymentIntentTransferData.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Services/PaymentIntents/PaymentIntentTransferDataOptions.cs
Outdated
Show resolved
Hide resolved
remi-stripe
force-pushed
the
remi-fix-payment-intent
branch
from
f7e26ce to
ac6cb2a
Compare
|
@ob-stripe thanks for catching all the issues. PTAL. |
ob-stripe
suggested changes
Feb 21, 2019
src/Stripe.net/Services/PaymentIntents/PaymentIntentTransferDataOptions.cs
Outdated
Show resolved
Hide resolved
remi-stripe
force-pushed
the
remi-fix-payment-intent
branch
from
ac6cb2a to
064ab2a
Compare
ob-stripe
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1532 and other issues
r? @ob-stripe
cc @stripe/api-libraries