Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for backdate_start_date and cancel_at on Subscription #1548

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

remi-stripe
Copy link
Contributor

Add support for backdate_start_date and cancel_at on Subscription. This is gated but many users have access to it and I missed it while releasing SubscriptionSchedule.

r? @brandur-stripe
@stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-subs-fields branch from 033d07e to ca7aed2 Compare March 7, 2019 02:16
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, was just about to comment on that missing forward slash! Looks good to me.

@remi-stripe
Copy link
Contributor Author

Yeah, that'll teach me for not running the tests before pushing a comment change. "It's just a comment, what could go wrong".

@remi-stripe remi-stripe merged commit b6cf85a into master Mar 7, 2019
@remi-stripe remi-stripe deleted the remi-add-subs-fields branch March 7, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants