-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for address information on Customer
#1574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-customer-address
branch
2 times, most recently
from
April 10, 2019 21:33
f2c6ef8
to
200d39f
Compare
ob-stripe
suggested changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal @remi-stripe
remi-stripe
force-pushed
the
remi-add-customer-address
branch
from
April 10, 2019 22:30
200d39f
to
d140f53
Compare
@ob-stripe PTAL (nice catch) |
remi-stripe
force-pushed
the
remi-add-customer-address
branch
from
April 10, 2019 22:41
d140f53
to
c9c705e
Compare
ugh sorry, fixed for real this time. |
ob-stripe
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
remi-stripe
force-pushed
the
remi-add-customer-address
branch
from
April 17, 2019 22:13
c9c705e
to
cec89e7
Compare
remi-stripe
force-pushed
the
remi-add-customer-address
branch
from
April 17, 2019 22:17
cec89e7
to
5ed1a43
Compare
remi-stripe
commented
Apr 17, 2019
@ob-stripe Added 2 new fields can you re-approve? |
ob-stripe
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries @robertcoe-stripe