Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merchant_amount merchant_currency to Issuing Transaction #1664

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

cjavilla-stripe
Copy link
Contributor

?r @remi-stripe
cc @stripe/api-libraries

@remi-stripe
Copy link
Contributor

LGTM but assigning to @ob-stripe since you changed other files

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Jun 14, 2019
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/issuing-transaction-merchant-amount branch from b9a82e8 to 8cef9c6 Compare June 14, 2019 17:11
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more tiny nit :)

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/issuing-transaction-merchant-amount branch from 8cef9c6 to ec5017d Compare June 14, 2019 17:39
@ob-stripe
Copy link
Contributor

LGTM, thanks @cjavilla-stripe! :)

@remi-stripe remi-stripe merged commit 349a329 into master Jun 14, 2019
@remi-stripe remi-stripe deleted the cjavilla/issuing-transaction-merchant-amount branch June 14, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants