-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for merchant_amount
merchant_currency
to Issuing Transaction
#1664
Merged
remi-stripe
merged 1 commit into
master
from
cjavilla/issuing-transaction-merchant-amount
Jun 14, 2019
Merged
Add support for merchant_amount
merchant_currency
to Issuing Transaction
#1664
remi-stripe
merged 1 commit into
master
from
cjavilla/issuing-transaction-merchant-amount
Jun 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM but assigning to @ob-stripe since you changed other files |
ob-stripe
suggested changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal @cjavilla-stripe
b9a82e8
to
8cef9c6
Compare
ob-stripe
suggested changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more tiny nit :)
8cef9c6
to
ec5017d
Compare
ob-stripe
approved these changes
Jun 14, 2019
LGTM, thanks @cjavilla-stripe! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?r @remi-stripe
cc @stripe/api-libraries