Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for iDEAL and SEPA debit on PaymentMethod #1830

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Nov 4, 2019

Multiple API changes

  • Add support for the Mandate API Resource
  • Add support for SEPA Debit and iDEAL on PaymentMethod
  • Add support for mandate on SetupIntent
  • Add support for mandate on PaymentIntent

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-mandate branch 3 times, most recently from e0e051b to 392da24 Compare November 6, 2019 02:16
@remi-stripe remi-stripe changed the title [WIP] Adding support for iDEAL and SEPA debit on PaymentMethod Adding support for iDEAL and SEPA debit on PaymentMethod Nov 6, 2019
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the separate commits and for adding tests!

@ob-stripe ob-stripe merged commit 37b1d49 into master Nov 6, 2019
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Nov 6, 2019
@ob-stripe ob-stripe deleted the remi-add-mandate branch November 6, 2019 18:48
@ob-stripe
Copy link
Contributor

Released as 33.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants