Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a few option classes to have Options in the name #1850

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

remi-stripe
Copy link
Contributor

This PR renames a few legacy option classes to have Options in the name instead of Option. This reverts a legacy decision we made a while ago to become consistent again.

  • InvoiceUpcomingInvoiceItemOption is now InvoiceUpcomingInvoiceItemOptions.
  • SubscriptionItemOption is now SubscriptionItemOptions.
  • SubscriptionItemUpdateOption is now merged into SubscriptionItemOptions.

r? @ob-stripe
cc @stripe/api-libraries

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Nov 25, 2019
@remi-stripe remi-stripe merged commit 21f7f61 into integration-v34 Nov 25, 2019
@remi-stripe remi-stripe deleted the rename-option-classes branch November 25, 2019 20:35
@remi-stripe remi-stripe mentioned this pull request Nov 25, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants