Add AuBecsDebit support on PaymentMethod #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
requested changes
Dec 6, 2019
There was a problem hiding this comment.
The changes look good to me but you are missing something in Mandate based on the java PR: https://github.com/stripe/stripe-java/pull/913/files
I recommend always working on stripe-java first. That way you don't have to try and find the changes, the PR automatically generated would tell you about the exact fields and it makes it easier for us to review.
Also, work with the local team to add docstrings to the new properties added so that you can add them in stripe-go
|
@remi-stripe Done, thanks for reviewing |
remi-stripe
requested changes
Dec 9, 2019
Code reveiw: add Au BECS Debit to Mandate.PaymentDetails Remove docs
shengwei-stripe
force-pushed
the
aubecsPm
branch
from
36aaa66 to
3bc2f4f
Compare
|
@remi-stripe Done |
remi-stripe
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@remi-stripe @ob-stripe
cc @stripe/api-libraries
Adding AU BECS Debit to PaymentMethod