Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Connect as obsolete on WebhookEndpoint and add documentation #1878

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Dec 12, 2019

Fix #1876

  • Deprecates Connect
  • Rename ApplicationId to Application (and keep the old one)
  • Add docs for all fields

r? @ob-stripe
cc @stripe/api-libraries

set => this.Application = value;
}

[Obsolete("This property was never returned. Use ApplicationId instead")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Obsolete("This property was never returned. Use ApplicationId instead")]
[Obsolete("This property was never returned. Use Application instead")]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thank you!

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Dec 13, 2019
@remi-stripe remi-stripe force-pushed the webhook-remove-connect branch from 61440ab to 613e21b Compare December 13, 2019 16:12
@remi-stripe remi-stripe merged commit 34cf2c6 into master Dec 13, 2019
@remi-stripe remi-stripe deleted the webhook-remove-connect branch December 13, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebhookEndpoint.Connect is always false
2 participants