Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ExecutivesProvided to AccountCompany #1888

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

cjavilla-stripe
Copy link
Contributor

Adds ExecutivesProvided to AccountCompany

r? @remi-stripe
cc @stripe/api-libraries

@@ -29,6 +29,15 @@ public class AccountCompany : StripeEntity<AccountCompany>
[JsonProperty("directors_provided")]
public bool DirectorsProvided { get; set; }

/// <summary>
/// Whether the company's executives have been provided. Set this
/// Boolean to `true` after creating all the company's executives with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true should be <c>true</c> instead in dotnet and links should instead use

<a href="https://stripe.com/docs/subscriptions/webhooks">Using Webhooks with
        /// Subscriptions</a>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. fixing

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need to be fixed

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-execs-provided branch from efbfeca to 3b78604 Compare December 20, 2019 22:57
@cjavilla-stripe
Copy link
Contributor Author

r? @remi-stripe

fixed docs. ptal.

/// Whether the company's executives have been provided. Set this
/// Boolean to <c>true</c> after creating all the company's executives with
/// <a href="https://stripe.com/docs/api/persons">the Persons API</a> for
/// accounts with a <c>relationship.executive</c> requirement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we use <see cref="Invoice"/> and such for those

@remi-stripe remi-stripe merged commit 55181b5 into master Dec 21, 2019
@remi-stripe remi-stripe deleted the cjavilla/add-execs-provided branch December 21, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants