Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing parameters when deleting a Subscription Item #1932

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Add support for passing parameters when deleting a Subscription Item #1932

merged 2 commits into from
Mar 3, 2020

Conversation

remi-stripe
Copy link
Contributor

Fixes #1931

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe mentioned this pull request Feb 27, 2020
Closed
@remi-stripe remi-stripe changed the base branch from master to integration-v35 February 28, 2020 06:17
@remi-stripe
Copy link
Contributor Author

@ob-stripe I added parameters for all Delete methods. That PR also adds the SubscriptionItemDeleteOptions parameters. The API doesn't yet support proration_behavior but it's being built right now

@remi-stripe remi-stripe assigned ob-stripe and unassigned ob-stripe Feb 28, 2020
ob-stripe
ob-stripe suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Amazing, thanks @remi-stripe!

One request, but otherwise LGTM.

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Feb 28, 2020
@ob-stripe ob-stripe mentioned this pull request Feb 28, 2020
Merged
6 tasks
@remi-stripe
Copy link
Contributor Author

Fixed, PTAL @ob-stripe

@remi-stripe remi-stripe merged commit a6ab693 into integration-v35 Mar 3, 2020
@remi-stripe remi-stripe deleted the remi-subitem-delete branch March 3, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved breaking-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Delete SubscriptionItem should take options to set prorate = false
3 participants
@remi-stripe @ob-stripe @stripe-ci