Remove all beta properties and parameters from the Issuing API #1968
Conversation
remi-stripe
force-pushed
the
integration-v36
branch
from
50e6851 to
32b877d
Compare
remi-stripe
force-pushed
the
remi-issuing-remove-pre-ga
branch
from
da8f3d7 to
32d0209
Compare
|
@remi-stripe Same, should we close this for now? |
remi-stripe
changed the title
|
I'd like to keep the PR but I changed the title to be clear it's on hold until later this week |
ob-stripe
force-pushed
the
integration-v36
branch
from
32b877d to
bfb0674
Compare
|
I've reset the |
remi-stripe
force-pushed
the
remi-issuing-remove-pre-ga
branch
2 times, most recently
from
34675ef to
48a03c1
Compare
remi-stripe
changed the title
remi-stripe
force-pushed
the
remi-issuing-remove-pre-ga
branch
3 times, most recently
from
0c10df0 to
cdcacc3
Compare
| /// <summary> | ||
| /// The cardholder’s billing address. | ||
| /// </summary> | ||
| [JsonProperty("billing")] | ||
| public Billing Billing { get; set; } | ||
| public CardholderBilling Billing { get; set; } |
There was a problem hiding this comment.
This is one where I'm not sure of this decision. I originally used Billing to mirror what we do in our payments APIs because billing is often a common hash we share. Here though I think mirroring the spec is cleaner and will help codegen for dotnet in the future.
cc @cjavilla-stripe as we recently changed the docs so we'll need to revert that
There was a problem hiding this comment.
we decided to mirror java and the spec so this change is approved
| @@ -5,54 +5,25 @@ namespace Stripe.Issuing | |||
| using Newtonsoft.Json; | |||
| using Stripe.Infrastructure; | |||
|
|
|||
| public class Dispute : StripeEntity<Dispute>, IHasId, IHasMetadata, IHasObject | |||
| public class Dispute : StripeEntity<Dispute>, IHasId, IHasObject | |||
There was a problem hiding this comment.
We limited the Issuing Dispute API entirely for now as we re-design it.
| [JsonIgnore] | ||
| public string AuthorizationId | ||
| { | ||
| get => this.InternalAuthorization?.Id; | ||
| set => this.InternalAuthorization = SetExpandableFieldId(value, this.InternalAuthorization); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// (Expanded)) The <see cref="Authorization"/> associated with this transaction. |
There was a problem hiding this comment.
Should only be one close paren here, I think
| [JsonIgnore] | ||
| public string BalanceTransactionId | ||
| { | ||
| get => this.InternalBalanceTransaction?.Id; | ||
| set => this.InternalBalanceTransaction = SetExpandableFieldId(value, this.InternalBalanceTransaction); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// (Expanded)) The <see cref="BalanceTransaction"/> associated with this transaction. |
There was a problem hiding this comment.
s/(Expanded))/(Expanded)
| [JsonIgnore] | ||
| public string CardId | ||
| { | ||
| get => this.InternalCard?.Id; | ||
| set => this.InternalCard = SetExpandableFieldId(value, this.InternalCard); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// (Expanded)) The <see cref="Card"/> associated with this transaction. |
There was a problem hiding this comment.
s/(Expanded))/(Expanded)
remi-stripe
force-pushed
the
remi-issuing-remove-pre-ga
branch
from
cdcacc3 to
32ebd0e
Compare
|
Fixed, waiting for tests to pass to be safe and then merging |
This PR removes all the deprecated features associated with Issuing's beta before the GA happened. It also cleans up naming of various classes to mirror our current logic based on the openapi spec to ensure we will codegen the information reliably.
r? @richardm-stripe
cc @stripe/api-libraries