Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the BillingPortal namespace and the Session API and resource #1998

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

remi-stripe
Copy link
Contributor

cc @stripe/api-libraries
cc @alexander-stripe

@remi-stripe remi-stripe changed the title [WIP] Add support for the BillingPortal namespace and the Session API and resource Add support for the BillingPortal namespace and the Session API and resource Apr 22, 2020
@remi-stripe
Copy link
Contributor Author

r? @cjavilla-stripe

This mirrors stripe/stripe-java#1014 in stripe-java

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding these!

@@ -21,6 +21,7 @@ public static class StripeTypeRegistry
{ "balance", typeof(Balance) },
{ "balance_transaction", typeof(BalanceTransaction) },
{ "bank_account", typeof(BankAccount) },
{ "billing_portal.session", typeof(BillingPortal.Session) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite sure how this bit works, but it seems to match the issuing ones, so lgtm

@remi-stripe remi-stripe merged commit 44a449f into master Apr 22, 2020
@remi-stripe remi-stripe deleted the remi-add-portal branch April 22, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants