Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple missing features and better docs #2053

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

remi-stripe
Copy link
Contributor

This PR cleans up more of the library based on what codegen finds today. It should help reduce the diff between the codegen branch and master. While doing it, I added comments to core resources too.

New features:

  • Add NetworkReasonCode on Dispute which is a gated feature
  • Fix RefundId on OrderReturn, CustomerId on Order and BalanceTransactionId on Topup to be deserialized properly
  • Add Deleted on ValueList and ValueListItem
  • Add BillingThresholds on SubscriptionItem

r? @cjavilla-stripe
cc @stripe/api-libraries

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome update

@remi-stripe remi-stripe merged commit dd44018 into master May 20, 2020
@remi-stripe remi-stripe deleted the remi-codegen-fixes branch July 24, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants