Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ProductData on SessionLineItemPriceDataOptions #2057

Merged
merged 1 commit into from
May 28, 2020

Conversation

remi-stripe
Copy link
Contributor

r? @cjavilla-stripe
cc @stripe/api-libraries

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about return type of Description

/// additional information about the object in a structured format.
/// </summary>
[JsonProperty("description")]
public Dictionary<string, string> Description { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be a String, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed PTAL

@remi-stripe remi-stripe force-pushed the remi-session-product-data branch from 28c8af3 to f808421 Compare May 28, 2020 17:03
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remi-stripe remi-stripe merged commit 663c42b into master May 28, 2020
@remi-stripe remi-stripe deleted the remi-session-product-data branch May 28, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants