Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BACS Debit as a Capability on Account #2063

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

remi-stripe
Copy link
Contributor

r? @cjavilla-stripe
cc @stripe/api-libraries

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,6 +12,13 @@ public class AccountCapabilities : StripeEntity<AccountCapabilities>
[JsonProperty("au_becs_debit_payments")]
public string AuBecsDebitPayments { get; set; }

/// <summary>
/// The status of the Bacs Direct Debits payments capability of the account, or whether the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we want to add the values in the comment here? active, inactive, or pending? non blocking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's the same for all of these so maybe doesn't make sense to add to all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it'd be repeated and the alignment of the comments is often different based on the previous sentence so it's a pain to do by hand :p

@remi-stripe remi-stripe merged commit b96a575 into master Jun 3, 2020
@remi-stripe remi-stripe deleted the remi-add-bacs-debit-details branch June 3, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants