Avoid async in autopagination when NET461 #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
changed the title
ob-stripe
approved these changes
Oct 29, 2020
|
Thanks @richardlawley @ob-stripe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2223.
Uses a preprocessor directive so that
ListRequestAutoPagingavoids trying to be async in NET461 (which breaks webforms), and uses something identical to the previous (sync) iteration: https://github.com/stripe/stripe-dotnet/blob/master/src/Stripe.net/Services/_base/Service.cs#L260Thanks @ob-stripe for pairing with me on the implementation of this.
r? @ob-stripe
cc @remi-stripe