API Updates #2366
Merged
API Updates #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Aug 31, 2021
| /// </summary> | ||
| [JsonProperty("expires_at")] | ||
| [JsonConverter(typeof(UnixDateTimeConverter))] | ||
| public DateTime? ExpiresAt { get; set; } |
There was a problem hiding this comment.
Why is this nullable? Shouldn't it be either always set or the entire hash is null?
There was a problem hiding this comment.
Good catch - from the checkout team:
after_expiration.recovery.enabledshould be required -after_expiration.recovery.allow_promotion_codesis optional on the write side with a default of false - so the resource [should] have that field as required as well.after_expiration.recovery.urlandafter_expiration.recovery.expires_atwill be null until the Checkout Session expires, so those are correct
remi-stripe
approved these changes
Aug 31, 2021
|
re-r? @remi-stripe with the latest changes |
remi-stripe
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 944e56f.
r? @dcr-stripe
cc @stripe/api-libraries
Changelog
AfterExpiration,ConsentCollection, andExpiresAtonCheckoutSessionCreateOptionsandCheckoutSessionConsentandRecoveredFromonCheckoutSession