Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #2375

Merged
merged 1 commit into from
Oct 7, 2021
Merged

API Updates #2375

merged 1 commit into from
Oct 7, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi d0904af.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for PhoneNumberCollection on CheckoutSessionCreateOptions and CheckoutSession
  • Add support for Phone on CheckoutSessionCustomerDetails

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though do we want to add

Add support for new value bbpos_wisepos_e on enum Terminal.Reader.device_type

to the changelog similar to stripe/stripe-php#1187?

@richardm-stripe
Copy link
Contributor Author

@dcr-stripe I don't think so, because it's just a change to the docstring and doesn't materially affect the library. In stripe-php the PHPDoc is used for typechecking/static analysis so it's a little different.

@richardm-stripe richardm-stripe merged commit 49b96b9 into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants