API Updates #2415
Merged
API Updates #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Jan 20, 2022
| public void TestPaymentLinkServiceListLineItems() | ||
| { | ||
| var service = new PaymentLinkService(this.StripeClient); | ||
| service.ListLineItems("pl_xyz"); |
There was a problem hiding this comment.
Those tests are quite lacking. Old tests checked the return class and its object property and all that no?
There was a problem hiding this comment.
I agree. Checking the return class seems a little redundant since that is already enforced by the static type, but I'll look into seeing if we can add object property checks to these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi 4d2f301.
r? @yejia-stripe
cc @stripe/api-libraries
Changelog
PaymentLinkPaymentLinkonCheckoutSession