Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Coveralls command line arguments #2570

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Aug 29, 2022

Summary

r? @pakrym-stripe

Update Coveralls command line arguments to account for both push and pull request events.

Example build for pull request: https://coveralls.io/builds/52036808
Example build for push: https://coveralls.io/builds/52036814

@anniel-stripe anniel-stripe changed the title Add pullRequestId parameter and update commitBranch and commitAuthor … Update Coveralls command line parameters Aug 29, 2022
@anniel-stripe anniel-stripe changed the title Update Coveralls command line parameters Update Coveralls command line arguments Aug 29, 2022
@anniel-stripe anniel-stripe marked this pull request as ready for review August 29, 2022 18:37
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, dotnet is so involved compared to other languages. Great job figuring this out.

@anniel-stripe anniel-stripe merged commit c410664 into master Aug 29, 2022
@anniel-stripe anniel-stripe deleted the anniel-coveralls-update branch August 29, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants