Fix missing IDisposable using #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pakrym-stripe
approved these changes
Dec 22, 2022
|
Is there anything else to be done for this one to merge? |
|
Thanks for following up @NoahStahl! Looks like this one fell through the cracks. Triggering the merge. Also thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running InferSharp on a project using this library, a finding came up for a missing
usingfor anIDisposable. After adding this, the warning is resolved. So, figured it would be nice to fix to avoid confusion for stripe-dotnet users who use this tool.I attempted to run the tests but don't have the mock service in place, so I haven't verified that aspect. If needed, I can pursue.
The finding message, for reference: