Modify SessionCustomTextOptions to align with checkout api #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
API Updates for beta branch
Bring New Checkout Session Custom Text to be compatible with Stripe API Version 2022-11-15
|
|
anniel-stripe
requested changes
Feb 13, 2023
|
Hey thanks, I wasn't sure where to point PRs to. I adjusted it to master. Let me know if there's anything else you need, and thanks for reviewing! |
anniel-stripe
requested changes
Feb 15, 2023
There was a problem hiding this comment.
Ah sorry I should have clarified, can you revert your merge with beta too (3d8eedb)? We don't want to merge those changes into master.
It may be easier to open a new PR, or wait until tomorrow's release where we plan to address this.
Merged
|
As an update, this was fixed in v41.7.0 after we updated our generator (we discovered this issue also existed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring New Checkout Session Custom Text to be compatible with Stripe API Version 2022-11-15
This fixes the src/Stripe.net/Services/Checkout/Sessions/SessionCustomTextOptions.cs model, in which it currently has type AddressOptions for SessionCustomTextOptions.ShippingAddress, which does not align with stripe API definitions. This throws API exceptions when used.
SessionCustomTextOptions.ShippingAddress should be an object with a single "message" property.
See https://stripe.com/docs/api/checkout/sessions/create for details on parameters expected for this.