Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to the Upcoming Invoice API #2646

Merged
merged 1 commit into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/Stripe.net/Services/Invoices/UpcomingInvoiceOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ public class UpcomingInvoiceOptions : BaseOptions
[JsonProperty("coupon")]
public string Coupon { get; set; }

[JsonProperty("currency")]
public string Currency { get; set; }

[JsonProperty("customer")]
public string Customer { get; set; }

Expand All @@ -34,6 +37,9 @@ public class UpcomingInvoiceOptions : BaseOptions
[JsonProperty("schedule")]
public string Schedule { get; set; }

[JsonProperty("subscription")]
public string Subscription { get; set; }

[JsonProperty("subscription_billing_cycle_anchor")]
[JsonConverter(typeof(AnyOfConverter))]
public AnyOf<DateTime?, SubscriptionBillingCycleAnchor> SubscriptionBillingCycleAnchor { get; set; }
Expand All @@ -51,9 +57,6 @@ public class UpcomingInvoiceOptions : BaseOptions
[JsonProperty("subscription_default_tax_rates")]
public List<string> SubscriptionDefaultTaxRates { get; set; }

[JsonProperty("subscription")]
public string Subscription { get; set; }

[JsonProperty("subscription_items")]
public List<InvoiceSubscriptionItemOptions> SubscriptionItems { get; set; }

Expand All @@ -68,6 +71,10 @@ public class UpcomingInvoiceOptions : BaseOptions
[JsonConverter(typeof(UnixDateTimeConverter))]
public DateTime? SubscriptionProrationDate { get; set; }

[JsonProperty("subscription_resume_at")]
[JsonConverter(typeof(AnyOfConverter))]
public AnyOf<DateTime?, UpcomingInvoiceSubscriptionResumeAt> SubscriptionResumeAt { get; set; }

[JsonProperty("subscription_start_date")]
[JsonConverter(typeof(UnixDateTimeConverter))]
public DateTime? SubscriptionStartDate { get; set; }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
namespace Stripe
{
public class UpcomingInvoiceSubscriptionResumeAt : StringEnum
{
/// <summary>When viewing an upcoming invoice for a subscription, simulates it resuming to the current time.</summary>
public static readonly UpcomingInvoiceSubscriptionResumeAt Now
= new UpcomingInvoiceSubscriptionResumeAt("now");

private UpcomingInvoiceSubscriptionResumeAt(string value)
: base(value)
{
}
}
}
16 changes: 16 additions & 0 deletions src/StripeTests/Services/Invoices/UpcomingInvoiceOptionsTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,22 @@ public void SerializeSubscriptionBillingCycleAnchor()
},
want = "subscription_trial_end=now",
},
new
{
options = new UpcomingInvoiceOptions
{
SubscriptionResumeAt = DateTime.Parse("Fri, 13 Feb 2009 23:31:30Z"),
},
want = "subscription_resume_at=1234567890",
},
new
{
options = new UpcomingInvoiceOptions
{
SubscriptionResumeAt = UpcomingInvoiceSubscriptionResumeAt.Now,
},
want = "subscription_resume_at=now",
},
};

foreach (var testCase in testCases)
Expand Down