Remove incorrect child service methods #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice and Invoices/InvoiceService added missing Update methods to InvoiceService.partial.cs updated comments in v2 event files
ramya-stripe
approved these changes
Sep 30, 2024
…ested-child-services-special-case
jar-stripe
deleted the
jar/dotnet-remove-inline-nested-child-services-special-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In the upcoming release, we are splitting child service methods from services like Checkout/Sessions/SessionService to more descriptive, self contained services e.g. SessionLineItemService. We are maintaining the old methods (now marked obsolete) for backwards compatibility purposes, but there were other methods that were also added to the parent service that we need to remove. This PR removes those methods and also restores the UpdateLines and UpdateLinesAsync methods to InvoiceService.
What?