Fix V2 list options base class #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated V2 list options subclasses to derive from V2.ListOptions
|
The compat issues are expected because we're correcting the base class of two list options classes to use the V2 ListOptions base class. |
xavdid-stripe
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
API V2 lists have different semantics than lists in V1. In this SDK, we utilize a ListOptions base class to hold common options. We need to introduce a V2 specific ListOptions base class to ensure the V2 list semantics are correctly represented. This PR introduces this base class and updates V2 list options subclasses to derive from it instead of the V1 ListOptions class.
What
Changelog
StartingAfterandEndingBeforeproperties fromStripe.V2.EventListOptionsandStripe.V2.EventDestinationListOptions. These properties are not supported on V2 List APIs and would result in a HTTP 400 error if provided.