System.Text.Json Serialization Support in .NET SDK Objects #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified PropertiesHaveJsonAttributes to check for equivalent STJ attributes
…son attributes added json converters for system text json to ensure we conform to our API and existing SDK behavior
migrated manually managed files
updated wholesome tests for better reporting
updated classes with Deleted properties
added NewtonsoftAndSystemTextJsonOutputTheSameObject wholesome test, to ensure all stripe entities serialize the same through json.net and system text json added STJEnumerableObjectConverter because STJ serializes IEnumerable implementations as arrays and not objects
added test to verify that enumerable item types have the proper STJ converters updated wholesome tests
jar-stripe
changed the title
jar-stripe
requested review from
pakrym-stripe,
a team,
xavdid-stripe and
prathmesh-stripe
and removed request for
a team and
xavdid-stripe
…pe-dotnet into jar/coexist-system-text-json
|
The build failure is not expected, and appears to be due to a significant difference between .NET 6 and .NET 8. |
…nt JsonObject(MemberSerialization.OptIn) functionality in System Text Json. This is needed because JsonInclude does not work the same in .NET 6 and .NET 7 as it does in .NET 8 added SerializablePropertyCache and other supporting classes converted several converters to converter factories, for type safety updated comments updated generated code
…nverter added wholesome test for member serialization opt in converter annotation updated WholesomeTest GetProperties to use more accurate selector
src/Stripe.net/Infrastructure/JsonConverters/STJAnyOfConverter.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Infrastructure/JsonConverters/STJStripeObjectConverter.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Infrastructure/JsonConverters/STJStripeObjectConverter.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Infrastructure/JsonConverters/STJStripeObjectConverter.cs
Show resolved
Hide resolved
…events are properly serializes refactored custom serialization to pull out common reusable logic updated wholesome tests to verify lists of V2 event subclasses and the custom converter updated no attributes needed attribute string with better descriptions removed GetRawText calls; we can use the JsonElement directly
added section to readme
jar-stripe
requested review from
helenye-stripe
and removed request for
prathmesh-stripe
helenye-stripe
approved these changes
Dec 12, 2024
|
Compat failures are expected and ok, and appear to be because of this change: https://github.com/stripe/sdk-codegen/pull/1954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Users reported in #2495 and #1979 that Stripe.net objects did not behave as expected when serialized using System.Text.Json. System.Text.Json has become the standard for modern .NET, and the Stripe.net SDK objects should support serializing using it.
What?
Changelog