Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AU BECS Debit Support #952

Merged
merged 8 commits into from
Oct 1, 2019
Merged

Add AU BECS Debit Support #952

merged 8 commits into from
Oct 1, 2019

Conversation

shengwei-stripe
Copy link
Contributor

@shengwei-stripe shengwei-stripe commented Sep 19, 2019 •
edited by remi-stripe
Loading

@remi-stripe @ob-stripe
I am adding AUBECS Support here. Have tested locally and running fine.

cc @stripe/api-libraries

@remi-stripe remi-stripe self-assigned this Sep 19, 2019
remi-stripe
remi-stripe requested changes Sep 20, 2019
View reviewed changes
charge.go Show resolved Hide resolved
charge.go Outdated Show resolved Hide resolved
source.go Show resolved Hide resolved
@shengwei-stripe shengwei-stripe mentioned this pull request Sep 20, 2019
Merged
remi-stripe
remi-stripe requested changes Sep 20, 2019
View reviewed changes
source.go Show resolved Hide resolved
remi-stripe
remi-stripe requested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All classes/constants need to be renamed and you have a linter error

charge.go Outdated Show resolved Hide resolved
charge.go Outdated Show resolved Hide resolved
source.go Show resolved Hide resolved
@remi-stripe
Copy link
Contributor

LGTM so re-assigning to @ob-stripe for final review

@remi-stripe
Copy link
Contributor

Ah nevermind the tests are still not passing @shengwei-stripe so you need to fix those first https://travis-ci.org/stripe/stripe-go/builds/589864653?utm_source=github_status&utm_medium=notification

golint -set_exit_status ./...
source.go:187:6: exported type SourceMandateAcceptanceOnlineParams should have comment or be unexported
source.go:193:6: exported type SourceMandateAcceptanceOfflineParams should have comment or be unexported

You should run make all locally to launch all tests including the linter

@remi-stripe
Copy link
Contributor

LGTM so re-assigning to @ob-stripe for final review

ob-stripe
ob-stripe approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@remi-stripe remi-stripe merged commit 4c22954 into stripe:master Oct 1, 2019
nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
@jmather-c
Added a readme file to the data directory to describe the purpose of …
63d522d 
…the sample data and open api document files. (#952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

@remi-stripe remi-stripe Awaiting requested review from remi-stripe

Assignees

@shengwei-stripe shengwei-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shengwei-stripe @remi-stripe @ob-stripe @stripe-ci