Skip to content

Commit

Permalink
Update Mastercard and Apple Pay branding (#1374)
Browse files Browse the repository at this point in the history
* Update Mastercard and Apple Pay branding

* Fixed 3x image

* Fixed 1x image
  • Loading branch information
davidme-stripe authored Sep 18, 2019
1 parent 0519719 commit 720c765
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 6 deletions.
8 changes: 8 additions & 0 deletions Example/UI Examples/Stripe UI Examples.entitlements
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.developer.in-app-payments</key>
<array/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion Stripe/PublicHeaders/STPAPIClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static NSString *const STPSDKVersion = @"17.0.1";
@property (class, nonatomic, getter=isJCBPaymentNetworkSupported) BOOL JCBPaymentNetworkSupported __attribute__((deprecated("Set additionalApplePayNetworks = @[PKPaymentNetworkJCB] instead")));

/**
The SDK accepts Amex, MasterCard, Visa, and Discover for Apple Pay.
The SDK accepts Amex, Mastercard, Visa, and Discover for Apple Pay.
Set this property to enable other card networks in addition to these.
For example, `additionalEnabledApplePayNetworks = @[PKPaymentNetworkJCB];` enables JCB (note this requires onboarding from JCB and Stripe).
Expand Down
2 changes: 1 addition & 1 deletion Stripe/PublicHeaders/STPCardBrand.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ typedef NS_ENUM(NSInteger, STPCardBrand) {
STPCardBrandAmex,

/**
MasterCard card
Mastercard card
*/
STPCardBrandMasterCard,

Expand Down
2 changes: 1 addition & 1 deletion Stripe/PublicHeaders/STPImageLibrary.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ NS_ASSUME_NONNULL_BEGIN
+ (UIImage *)jcbCardImage;

/**
An icon representing MasterCard.
An icon representing Mastercard.
*/
+ (UIImage *)masterCardCardImage;

Expand Down
Binary file modified Stripe/Resources/Images/stp_card_applepay.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Stripe/Resources/Images/stp_card_applepay@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Stripe/Resources/Images/stp_card_applepay@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Stripe/Resources/Images/stp_card_mastercard_template.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Stripe/Resources/Images/stp_card_mastercard_template@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Stripe/Resources/Images/stp_card_mastercard_template@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion Stripe/STPBINRange.m
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ @implementation STPBINRange
// JCB
@[@"35", @"35", @16, @(STPCardBrandJCB)],

// MasterCard
// Mastercard
@[@"50", @"59", @16, @(STPCardBrandMasterCard)],
@[@"22", @"27", @16, @(STPCardBrandMasterCard)],
@[@"67", @"67", @16, @(STPCardBrandMasterCard)], // Maestro
Expand Down
2 changes: 1 addition & 1 deletion Stripe/STPCardBrand.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
case STPCardBrandJCB:
return @"JCB";
case STPCardBrandMasterCard:
return @"MasterCard";
return @"Mastercard";
case STPCardBrandUnionPay:
return @"UnionPay";
case STPCardBrandVisa:
Expand Down
2 changes: 1 addition & 1 deletion Tests/Tests/STPCardBrandTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ - (void)testStringFromBrand {
XCTAssertEqualObjects(string, @"JCB");
break;
case STPCardBrandMasterCard:
XCTAssertEqualObjects(string, @"MasterCard");
XCTAssertEqualObjects(string, @"Mastercard");
break;
case STPCardBrandUnionPay:
XCTAssertEqualObjects(string, @"UnionPay");
Expand Down

0 comments on commit 720c765

Please sign in to comment.